Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix member dispose mutating global member options #1090

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix member dispose mutating global member options #1090

wants to merge 1 commit into from

Conversation

ajbura
Copy link
Contributor

@ajbura ajbura commented May 11, 2023

All the call members share options as single object and when one of the member get disposed it mutate the emitUpdate option from that global options object.

After this happening this._members observable in GroupCall stop getting update about changes happening in all Member.

@ajbura ajbura mentioned this pull request May 11, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@ajbura